blaginin commented on code in PR #16617:
URL: https://github.com/apache/datafusion/pull/16617#discussion_r2176061502
##########
datafusion/core/tests/physical_optimizer/test_utils.rs:
##########
@@ -629,25 +622,15 @@ pub fn build_group_by(input_schema: &SchemaRef, columns:
Vec<String>) -> Physica
PhysicalGroupBy::new_single(group_by_expr.clone())
}
-pub fn assert_plan_matches_expected(
- plan: &Arc<dyn ExecutionPlan>,
- expected: &[&str],
-) -> Result<()> {
- let expected_lines: Vec<&str> = expected.to_vec();
+pub fn plan_matches_expected(plan: &Arc<dyn ExecutionPlan>) -> Result<String> {
Review Comment:
from this name you'd expect that it checks that the plan matches but it does
not. should we call it `get_optimized_plan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
