zhuqi-lucas commented on code in PR #16630:
URL: https://github.com/apache/datafusion/pull/16630#discussion_r2176661122
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -493,13 +493,12 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
if self.enable_round_robin_tie_breaker && cmp_node == 1 {
match (&self.cursors[winner], &self.cursors[challenger]) {
(Some(ac), Some(bc)) => {
- let ord = ac.cmp(bc);
- if ord.is_eq() {
+ if ac == bc {
Review Comment:
I also change this to using eq instead of compare first, this should also
optimize some cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
