renato2099 commented on PR #1156: URL: https://github.com/apache/datafusion-python/pull/1156#issuecomment-3020970616
Hi @timsaucer , thanks for pushing on this, I think the main difference is that you are extending the `PyCatalog` whereas I am introducing a new `PyCatalogProvider`. Both approaches have their pros/cons, imho keeping the separation between catalogs and catalog_providers might make things clearer at the interface level. That said I don't have a feel what datafusion-python users might find better, i.e., more rigid+"clearer" APIs vs more fluid+a bit less clearer API by accepting different object types (catalogs and catalog_providers when registering providers). Maybe it is more pythonic to accept different object types? PR looks good to me overall though, thanks again! and sorry for the delay on my side :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
