renato2099 commented on PR #1156: URL: https://github.com/apache/datafusion-python/pull/1156#issuecomment-3018187257
Hi @timsaucer , I am sorry I wasn't able to complete this in time, but I had it still on my radar. I pushed my version yesterday after the holidays :) https://github.com/apache/datafusion-python/pull/1137 and after a quick look at your PR, it seems they are relatively similar. One thing is that you declared a new "catalog" module whereas I introduced a rust wrapper class for the python providers ... but it is very minor difference tbh , anyway let me take a closer look after work today though and provide some more useful input here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
