ryanschneider opened a new pull request, #1916: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1916
Like BigQuery and Snowflake, DuckDB also supports the 2nd `characters` argument to `TRIM`: https://duckdb.org/docs/stable/sql/functions/text.html#trimstring-characters - DuckDB was added to the list of dialects potentially expecting a comma - `test_duckdb_trim` is basically a copy of `test_bigquery_trim` using the proper dialect - `parse_trim` test was updated to exclude DuckDB alongside BigQuery and Snowflake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
