alamb commented on code in PR #16541:
URL: https://github.com/apache/datafusion/pull/16541#discussion_r2175736700
##########
.github/workflows/dev.yml:
##########
@@ -35,6 +80,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
+ with:
Review Comment:
why is this needed?
##########
.github/workflows/dev.yml:
##########
@@ -16,13 +16,58 @@
# under the License.
name: Dev
-on: [push, pull_request]
+on: [push, pull_request, workflow_dispatch]
concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
cancel-in-progress: true
jobs:
+ breaking-changes:
+ name: Breaking Changes Detection
+ runs-on: ubuntu-latest
+ if: github.event_name == 'pull_request'
+ permissions:
+ contents: read
+ pull-requests: write
+ issues: write
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ token: ${{ secrets.GITHUB_TOKEN }}
+
+ - name: Install Rust toolchain
+ uses: dtolnay/rust-toolchain@stable
+
+ - name: Install GitHub CLI
+ run: |
+ if ! command -v gh &> /dev/null; then
Review Comment:
As I understood it the Github hosted runners already have `gh` installed on
them -- thus this command to setup and install apt-get seems unecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
