Samyak2 commented on code in PR #16500:
URL: https://github.com/apache/datafusion/pull/16500#discussion_r2164580513
##########
datafusion/physical-plan/src/joins/cross_join.rs:
##########
@@ -632,7 +632,7 @@ impl<T: BatchTransformer> CrossJoinStream<T> {
}
self.join_metrics.output_batches.add(1);
- self.join_metrics.output_rows.add(batch.num_rows());
+ self.join_metrics.baseline.record_output(batch.num_rows());
Review Comment:
I have updated it to use `record_poll`. Could you check if that's what you
were looking for? It's my first time with this codebase, so I'm a little unsure
if I did the right thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
