Samyak2 commented on code in PR #16500:
URL: https://github.com/apache/datafusion/pull/16500#discussion_r2164583753
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -1212,12 +1213,19 @@ pub(crate) struct BuildProbeJoinMetrics {
pub(crate) input_rows: metrics::Count,
/// Number of batches produced by this operator
pub(crate) output_batches: metrics::Count,
- /// Number of rows produced by this operator
- pub(crate) output_rows: metrics::Count,
+}
+
+impl Drop for BuildProbeJoinMetrics {
Review Comment:
I agree. This is not intuitive at all. When I came back to this PR to act on
your suggestions, it took me a while to remember how this works :)
I have added a comment for now. I would be open to other ways of handling
this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
