gabotechs commented on issue #16248: URL: https://github.com/apache/datafusion/issues/16248#issuecomment-3001436651
I imagine that in the same what you were able to encode the extra information about the types in https://github.com/apache/datafusion/pull/16503 as different variations of the same type, there could be an opportunity for doing the same thing with this other types. I'm not sure how well this approach could fit for a `Float16` though... Having Substrait's Fp32 type have a type variation that downgrades to Fp16 seems a bit weird when the type name is explicitly stating that it's a 32 bit floating point number. I've asked the question here https://github.com/substrait-io/substrait/issues/822, and my intuition tells me that the answer to that question could also set the path forward for other types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
