adriangb commented on issue #16511: URL: https://github.com/apache/datafusion/issues/16511#issuecomment-3001322864
> Make it a new physical optimizer rule? Or add them to the current physical filter push down Do we need a phyiscal optimizer rule? My thought is that these optimizations can happen at the logical layer. At the phyiscal layer we do need some expression optimization, but primarily to deal with type casting to match the file schema, etc (i.e. https://github.com/apache/datafusion/pull/16530), expressions at this point should be already simplified from the logical layer and that doesn't really change except maybe in some edge cases which I'm not sure are worth dealing with. > Some filters, such as partition columns related predicates, will be fully pushed down scan, that is, we don't have such predicates in some FilterExec. How to capture this? Not sure I understood this part -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
