pepijnve commented on PR #16398: URL: https://github.com/apache/datafusion/pull/16398#issuecomment-2989086637
@alamb @Dandandan I'm starting to get the feeling this is a wild goose chase. I adapted `bench.sh` a bit so that I can pass in `--query`. I then ran `clickbench_1` query 4 multiple times since that showed a particularly large slowdown in your run. Here's what I got. Depending on the whims of the benchmark gods the runs are sometimes faster, sometimes slower. I'm not sure if you can make any meaningful conclusion based on these timings alone. I'll try to have a look at performance counters next, maybe that paints a clearer picture. ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Query ┃ baseline ┃ branch ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ QQuery 4 │ 408.42 / 416.77 ±10.99 / 437.63 ms │ 427.32 / 453.68 ±23.80 / 496.62 ms │ slower │ │ QQuery 4 │ 412.03 / 420.43 ±9.88 / 439.50 ms │ 413.27 / 426.28 ±8.92 / 437.55 ms │ no change │ │ QQuery 4 │ 416.20 / 426.53 ±5.67 / 432.79 ms │ 426.05 / 431.55 ±7.22 / 444.22 ms │ no change │ │ QQuery 4 │ 409.48 / 417.30 ±8.24 / 431.85 ms │ 406.66 / 419.13 ±11.66 / 438.14 ms │ no change │ │ QQuery 4 │ 407.35 / 421.29 ±10.34 / 436.56 ms │ 418.82 / 433.02 ±14.18 / 458.39 ms │ no change │ │ QQuery 4 │ 409.18 / 421.46 ±9.34 / 437.74 ms │ 409.45 / 418.36 ±10.57 / 438.11 ms │ no change │ │ QQuery 4 │ 407.54 / 418.17 ±9.50 / 435.26 ms │ 413.72 / 423.48 ±7.94 / 434.72 ms │ no change │ │ QQuery 4 │ 406.85 / 417.14 ±10.05 / 436.24 ms │ 406.06 / 416.47 ±8.68 / 428.46 ms │ no change │ │ QQuery 4 │ 405.30 / 416.89 ±13.20 / 441.77 ms │ 405.34 / 415.79 ±12.40 / 439.34 ms │ no change │ └──────────────┴────────────────────────────────────┴────────────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org