zhuqi-lucas commented on PR #15380: URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2988212099
I am still confused why my local mac no regression for this PR: ```rust -------------------- Benchmark sort_tpch1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ concat_batches_for_sort ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 153.49 ms │ 141.31 ms │ +1.09x faster │ │ Q2 │ 131.29 ms │ 113.30 ms │ +1.16x faster │ │ Q3 │ 980.57 ms │ 986.14 ms │ no change │ │ Q4 │ 252.25 ms │ 215.03 ms │ +1.17x faster │ │ Q5 │ 464.81 ms │ 454.00 ms │ no change │ │ Q6 │ 481.44 ms │ 467.38 ms │ no change │ │ Q7 │ 810.73 ms │ 695.84 ms │ +1.17x faster │ │ Q8 │ 498.10 ms │ 502.47 ms │ no change │ │ Q9 │ 503.80 ms │ 506.87 ms │ no change │ │ Q10 │ 789.02 ms │ 709.34 ms │ +1.11x faster │ │ Q11 │ 417.39 ms │ 411.24 ms │ no change │ └──────────────┴───────────┴─────────────────────────┴───────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
