Dandandan commented on code in PR #16433:
URL: https://github.com/apache/datafusion/pull/16433#discussion_r2156106525
##########
datafusion/physical-plan/src/topk/mod.rs:
##########
@@ -214,41 +238,39 @@ impl TopK {
let mut selected_rows = None;
- if let Some(filter) = self.filter.as_ref() {
- // If a filter is provided, update it with the new rows
- let filter = filter.current()?;
- let filtered = filter.evaluate(&batch)?;
- let num_rows = batch.num_rows();
- let array = filtered.into_array(num_rows)?;
- let mut filter = array.as_boolean().clone();
- let true_count = filter.true_count();
- if true_count == 0 {
- // nothing to filter, so no need to update
- return Ok(());
+ // If a filter is provided, update it with the new rows
Review Comment:
`if let Some(filter)` condition is gone?
This provided the "unitialized filter" case before (that just runs the
normal topk without any filtering overhead).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
