Dandandan commented on PR #16433: URL: https://github.com/apache/datafusion/pull/16433#issuecomment-2985955904
It seems in some cases it's faster: ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ topk-dynamic-filter ┃ topk-filters ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 16.17 ms │ 16.89 ms │ no change │ │ Q2 │ 27.60 ms │ 20.22 ms │ +1.36x faster │ │ Q3 │ 55.41 ms │ 54.45 ms │ no change │ │ Q4 │ 22.26 ms │ 22.07 ms │ no change │ │ Q5 │ 11.98 ms │ 12.10 ms │ no change │ │ Q6 │ 26.25 ms │ 27.26 ms │ no change │ │ Q7 │ 71.56 ms │ 67.86 ms │ +1.05x faster │ │ Q8 │ 90.02 ms │ 46.15 ms │ +1.95x faster │ │ Q9 │ 61.64 ms │ 58.91 ms │ no change │ │ Q10 │ 101.13 ms │ 98.24 ms │ no change │ │ Q11 │ 58.43 ms │ 56.85 ms │ no change │ └──────────────┴─────────────────────┴──────────────┴───────────────┘ ``` And in other cases it's mixed / slower: ```┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ topk-dynamic-filter ┃ topk-filters ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 14.00 ms │ 13.07 ms │ +1.07x faster │ │ QQuery 1 │ 20.55 ms │ 18.81 ms │ +1.09x faster │ │ QQuery 2 │ 56.58 ms │ 56.33 ms │ no change │ │ QQuery 3 │ 56.30 ms │ 54.94 ms │ no change │ │ QQuery 4 │ 468.00 ms │ 516.71 ms │ 1.10x slower │ │ QQuery 5 │ 626.85 ms │ 659.29 ms │ 1.05x slower │ │ QQuery 6 │ 15.31 ms │ 15.26 ms │ no change │ │ QQuery 7 │ 30.44 ms │ 21.48 ms │ +1.42x faster │ │ QQuery 8 │ 547.48 ms │ 569.67 ms │ no change │ │ QQuery 9 │ 744.50 ms │ 778.67 ms │ no change │ │ QQuery 10 │ 182.53 ms │ 176.03 ms │ no change │ │ QQuery 11 │ 217.10 ms │ 190.23 ms │ +1.14x faster │ │ QQuery 12 │ 832.33 ms │ 715.38 ms │ +1.16x faster │ │ QQuery 13 │ 1102.37 ms │ 914.96 ms │ +1.20x faster │ │ QQuery 14 │ 823.97 ms │ 576.94 ms │ +1.43x faster │ │ QQuery 15 │ 574.53 ms │ 496.51 ms │ +1.16x faster │ │ QQuery 16 │ 1324.12 ms │ 1150.68 ms │ +1.15x faster │ │ QQuery 17 │ 1324.29 ms │ 1245.55 ms │ +1.06x faster │ │ QQuery 18 │ 2603.07 ms │ 2248.86 ms │ +1.16x faster │ │ QQuery 19 │ 48.17 ms │ 49.60 ms │ no change │ │ QQuery 20 │ 978.10 ms │ 964.90 ms │ no change │ │ QQuery 21 │ 1021.47 ms │ 1050.51 ms │ no change │ │ QQuery 22 │ 1958.07 ms │ 1660.81 ms │ +1.18x faster │ │ QQuery 23 │ 760.66 ms │ 5353.24 ms │ 7.04x slower │ │ QQuery 24 │ 525.78 ms │ 342.39 ms │ +1.54x faster │ │ QQuery 25 │ 480.36 ms │ 278.59 ms │ +1.72x faster │ │ QQuery 26 │ 542.13 ms │ 342.32 ms │ +1.58x faster │ │ QQuery 27 │ 1826.05 ms │ 1260.73 ms │ +1.45x faster │ │ QQuery 28 │ 11094.31 ms │ 10685.64 ms │ no change │ │ QQuery 29 │ 427.18 ms │ 432.16 ms │ no change │ │ QQuery 30 │ 826.43 ms │ 539.39 ms │ +1.53x faster │ │ QQuery 31 │ 789.89 ms │ 553.49 ms │ +1.43x faster │ │ QQuery 32 │ 2580.93 ms │ 2339.06 ms │ +1.10x faster │ │ QQuery 33 │ 2660.40 ms │ 2761.14 ms │ no change │ │ QQuery 34 │ 2948.08 ms │ 2923.44 ms │ no change │ │ QQuery 35 │ 886.56 ms │ 810.35 ms │ +1.09x faster │ │ QQuery 36 │ 18.59 ms │ 83.97 ms │ 4.52x slower │ │ QQuery 37 │ 18.67 ms │ 35.52 ms │ 1.90x slower │ │ QQuery 38 │ 18.10 ms │ 81.86 ms │ 4.52x slower │ │ QQuery 39 │ 17.89 ms │ 135.04 ms │ 7.55x slower │ │ QQuery 40 │ 18.30 ms │ 27.70 ms │ 1.51x slower │ │ QQuery 41 │ 18.15 ms │ 26.07 ms │ 1.44x slower │ │ QQuery 42 │ 17.78 ms │ 22.56 ms │ 1.27x slower │ └──────────────┴─────────────────────┴──────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
