adriangb commented on PR #16371: URL: https://github.com/apache/datafusion/pull/16371#issuecomment-2985997261
I'll try to review tomorrow. I took a look the other day and my thought was that while it's complex code that is a bit hard for me to fully wrap my head around it's well tested and isolated such that I highly doubt it would break any existing functionality, and if I understand correctly the functionality it does touch currently does not work at all, so it will be strictly an improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org