miclegr commented on code in PR #1154: URL: https://github.com/apache/datafusion-python/pull/1154#discussion_r2155423158
########## python/datafusion/context.py: ########## @@ -535,7 +535,7 @@ def register_listing_table( self, name: str, path: str | pathlib.Path, - table_partition_cols: list[tuple[str, str]] | None = None, + table_partition_cols: list[tuple[str, pa.DataType]] | None = None, Review Comment: That's fair, I opted for overloading and raising the deprecation warning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org