eliaperantoni opened a new pull request, #1893: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1893
At the moment, the `Span` of an `Ident` is used influences its ordering, but this doesn't seem consistent with the implementations of `PartialEq`, `Hash`, and the general guidelines for developing with `Span`: that they should be opaque information that doesn't influence the ordering or equality of the AST nodes. Which is the reason why `TokenWithSpan` was born. This PR change the implementation of `Ord` to ensure that it doesn't depend on the `Span`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
