pepijnve commented on code in PR #16398:
URL: https://github.com/apache/datafusion/pull/16398#discussion_r2152857840
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -743,6 +733,38 @@ pub enum EmissionType {
Both,
}
+/// Represents whether an operator's `Stream` has been implemented to actively
cooperate with the
+/// Tokio scheduler or not.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum SchedulingType {
+ /// The stream generated by [`execute`](ExecutionPlan::execute) does not
actively participate in
+ /// cooperative scheduling. This means the implementation of the `Stream`
returned by
+ /// [`ExecutionPlan::execute`] does not contain explicit cooperative yield
points.
Review Comment:
I kind of intentionally omitted that since it's describing the
implementation a bit too much. Trying to keep this as declarative as possible.
I renamed `Blocking` to `NonCooperative` which makes it sound less like a
bad thing. `NonCooperative` doesn't necessarily mean `make_cooperative`
wrappers will get inserted. That's only done for leave nodes and exchanges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
