iffyio commented on code in PR #1890:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1890#discussion_r2151983259
##########
tests/sqlparser_bigquery.rs:
##########
@@ -2407,3 +2459,16 @@ fn test_any_type() {
fn test_any_type_dont_break_custom_type() {
bigquery_and_generic().verified_stmt("CREATE TABLE foo (x ANY)");
}
+
+#[test]
+fn test_allow_options_in_struct_field() {
Review Comment:
```suggestion
fn test_struct_field_options() {
```
##########
src/ast/mod.rs:
##########
@@ -428,14 +428,22 @@ impl fmt::Display for Interval {
pub struct StructField {
pub field_name: Option<Ident>,
pub field_type: DataType,
+ // BigQuery supports options for struct fields.
+ // see [BigQuery]:
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema
Review Comment:
```suggestion
/// Struct field options.
/// see [BigQuery]:
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
