bombsimon commented on code in PR #1884:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1884#discussion_r2150373947
##########
src/parser/mod.rs:
##########
@@ -15096,12 +15096,16 @@ impl<'a> Parser<'a> {
transaction: Some(BeginTransactionKind::Transaction),
modifier: None,
statements: vec![],
- exception_statements: None,
+ exception: None,
has_end_keyword: false,
})
}
pub fn parse_begin(&mut self) -> Result<Statement, ParserError> {
+ if dialect_of!(self is SnowflakeDialect | BigQueryDialect) {
Review Comment:
I removed the use of `dialect_of!` macro and added it back to
`parse_statement` for Snowflake and BigQuery. This means that it will still not
work on `GenericDialect` but I assume that is correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
