comphead commented on code in PR #16083: URL: https://github.com/apache/datafusion/pull/16083#discussion_r2147425621
########## datafusion/physical-plan/src/joins/symmetric_hash_join.rs: ########## @@ -818,6 +822,20 @@ where .collect(); (build_indices, probe_indices) } + (JoinSide::Right, JoinType::RightMark) => { + let build_indices = (0..prune_length) + .map(L::Native::from_usize) + .collect::<PrimitiveArray<L>>(); + let probe_indices = (0..prune_length) + .map(|idx| { + // For mark join we output a dummy index 0 to indicate the row had a match Review Comment: that would be nice to show as an example, it is challenging to read algorithms for upcoming contributors, but it can be done as follow up PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org