kevinjqliu commented on PR #74: URL: https://github.com/apache/datafusion-site/pull/74#issuecomment-2967429852
also nit, any links with `https://github.com/apache/datafusion/blob/main/` runs into the risk of being stale at a later time. For example, if a file path was moved to a different location. It would be better to use a specific git hash like ``` [unwrap_cast](https://github.com/apache/datafusion/blob/8f3f70877febaa79be3349875e979d3a6e65c30e/datafusion/optimizer/src/simplify_expressions/unwrap_cast.rs#L70), ``` https://github.com/apache/datafusion-site/pull/74/files#diff-75edab122b58ff4a9a79c03ffa14767046dc8f8df5b511e4e3142cf5e01774edR286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
