pepijnve commented on PR #16319: URL: https://github.com/apache/datafusion/pull/16319#issuecomment-2963849416
I did a second identical run because those result seemed just too good to be true to me. This is much closer to what I was expecting: more or less status quo. That does mean I'm back to getting wildly differing results which I can't really explain. This is on an old repurposed PowerEdge r730 running in a Ubuntu 24.04 VM on esxi. It's the only VM on the machine so can't be noisy neighbors. Maybe the hardware is just starting to get flaky. <details> Comparing baseline and branch -------------------- Benchmark clickbench_extended.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Query ┃ baseline ┃ branch ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ QQuery 0 │ 2802.58 ms │ 2835.58 ms │ no change │ │ QQuery 1 │ 1267.40 ms │ 1254.16 ms │ no change │ │ QQuery 2 │ 2425.18 ms │ 2431.64 ms │ no change │ │ QQuery 3 │ 1049.51 ms │ 1096.84 ms │ no change │ │ QQuery 4 │ 2799.22 ms │ 2812.48 ms │ no change │ │ QQuery 5 │ 33146.06 ms │ 32438.14 ms │ no change │ │ QQuery 6 │ 3581.51 ms │ 3608.01 ms │ no change │ │ QQuery 7 │ 4244.94 ms │ 4316.87 ms │ no change │ │ QQuery 8 │ 1549.39 ms │ 1566.28 ms │ no change │ └──────────────┴─────────────┴─────────────┴───────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (baseline) │ 52865.81ms │ │ Total Time (branch) │ 52360.00ms │ │ Average Time (baseline) │ 5873.98ms │ │ Average Time (branch) │ 5817.78ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 9 │ │ Queries with Failure │ 0 │ └─────────────────────────┴────────────┘ -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ baseline ┃ branch ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 28.51 ms │ 28.65 ms │ no change │ │ QQuery 1 │ 66.92 ms │ 67.47 ms │ no change │ │ QQuery 2 │ 157.60 ms │ 158.95 ms │ no change │ │ QQuery 3 │ 149.93 ms │ 149.32 ms │ no change │ │ QQuery 4 │ 1168.56 ms │ 1192.96 ms │ no change │ │ QQuery 5 │ 1513.84 ms │ 1522.57 ms │ no change │ │ QQuery 6 │ 40.48 ms │ 41.31 ms │ no change │ │ QQuery 7 │ 82.32 ms │ 77.97 ms │ +1.06x faster │ │ QQuery 8 │ 1821.87 ms │ 1835.17 ms │ no change │ │ QQuery 9 │ 2179.03 ms │ 2154.90 ms │ no change │ │ QQuery 10 │ 535.16 ms │ 531.71 ms │ no change │ │ QQuery 11 │ 604.14 ms │ 595.35 ms │ no change │ │ QQuery 12 │ 1697.18 ms │ 1636.90 ms │ no change │ │ QQuery 13 │ 2807.76 ms │ 2802.55 ms │ no change │ │ QQuery 14 │ 1569.36 ms │ 1613.79 ms │ no change │ │ QQuery 15 │ 1627.10 ms │ 1627.11 ms │ no change │ │ QQuery 16 │ 3269.69 ms │ 3315.99 ms │ no change │ │ QQuery 17 │ 2856.85 ms │ 2846.55 ms │ no change │ │ QQuery 18 │ 6091.55 ms │ 5958.27 ms │ no change │ │ QQuery 19 │ 140.87 ms │ 138.93 ms │ no change │ │ QQuery 20 │ 1887.14 ms │ 1893.19 ms │ no change │ │ QQuery 21 │ 2269.57 ms │ 2281.36 ms │ no change │ │ QQuery 22 │ 3931.31 ms │ 3954.27 ms │ no change │ │ QQuery 23 │ 15449.02 ms │ 15582.96 ms │ no change │ │ QQuery 24 │ 854.06 ms │ 869.83 ms │ no change │ │ QQuery 25 │ 737.82 ms │ 728.33 ms │ no change │ │ QQuery 26 │ 958.68 ms │ 991.79 ms │ no change │ │ QQuery 27 │ 2704.35 ms │ 2695.40 ms │ no change │ │ QQuery 28 │ 22518.40 ms │ 22488.05 ms │ no change │ │ QQuery 29 │ 1172.40 ms │ 1178.97 ms │ no change │ │ QQuery 30 │ 1647.91 ms │ 1643.26 ms │ no change │ │ QQuery 31 │ 1716.99 ms │ 1726.10 ms │ no change │ │ QQuery 32 │ 5534.67 ms │ 5685.19 ms │ no change │ │ QQuery 33 │ 6824.90 ms │ 6887.88 ms │ no change │ │ QQuery 34 │ 7005.46 ms │ 7040.82 ms │ no change │ │ QQuery 35 │ 2293.87 ms │ 2313.10 ms │ no change │ │ QQuery 36 │ 165.05 ms │ 163.79 ms │ no change │ │ QQuery 37 │ 87.79 ms │ 84.71 ms │ no change │ │ QQuery 38 │ 165.88 ms │ 171.22 ms │ no change │ │ QQuery 39 │ 272.32 ms │ 275.14 ms │ no change │ │ QQuery 40 │ 77.26 ms │ 78.16 ms │ no change │ │ QQuery 41 │ 67.84 ms │ 67.96 ms │ no change │ │ QQuery 42 │ 61.56 ms │ 60.86 ms │ no change │ └──────────────┴─────────────┴─────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩ │ Total Time (baseline) │ 106812.96ms │ │ Total Time (branch) │ 107158.75ms │ │ Average Time (baseline) │ 2484.02ms │ │ Average Time (branch) │ 2492.06ms │ │ Queries Faster │ 1 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 42 │ │ Queries with Failure │ 0 │ └─────────────────────────┴─────────────┘ -------------------- Benchmark tpch_mem_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ baseline ┃ branch ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 1 │ 213.35 ms │ 202.86 ms │ no change │ │ QQuery 2 │ 35.88 ms │ 36.49 ms │ no change │ │ QQuery 3 │ 56.60 ms │ 54.00 ms │ no change │ │ QQuery 4 │ 35.63 ms │ 35.54 ms │ no change │ │ QQuery 5 │ 90.15 ms │ 87.55 ms │ no change │ │ QQuery 6 │ 20.33 ms │ 20.00 ms │ no change │ │ QQuery 7 │ 192.07 ms │ 185.72 ms │ no change │ │ QQuery 8 │ 38.70 ms │ 39.42 ms │ no change │ │ QQuery 9 │ 115.00 ms │ 114.61 ms │ no change │ │ QQuery 10 │ 77.92 ms │ 79.01 ms │ no change │ │ QQuery 11 │ 17.05 ms │ 17.88 ms │ no change │ │ QQuery 12 │ 91.61 ms │ 92.90 ms │ no change │ │ QQuery 13 │ 54.55 ms │ 52.40 ms │ no change │ │ QQuery 14 │ 15.72 ms │ 16.13 ms │ no change │ │ QQuery 15 │ 33.06 ms │ 32.31 ms │ no change │ │ QQuery 16 │ 35.86 ms │ 38.55 ms │ 1.07x slower │ │ QQuery 17 │ 147.53 ms │ 142.63 ms │ no change │ │ QQuery 18 │ 461.84 ms │ 468.67 ms │ no change │ │ QQuery 19 │ 43.45 ms │ 43.48 ms │ no change │ │ QQuery 20 │ 71.49 ms │ 73.57 ms │ no change │ │ QQuery 21 │ 298.95 ms │ 284.75 ms │ no change │ │ QQuery 22 │ 41.49 ms │ 41.23 ms │ no change │ └──────────────┴───────────┴───────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (baseline) │ 2188.25ms │ │ Total Time (branch) │ 2159.69ms │ │ Average Time (baseline) │ 99.47ms │ │ Average Time (branch) │ 98.17ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 21 │ │ Queries with Failure │ 0 │ └─────────────────────────┴───────────┘ </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
