pepijnve commented on PR #16319: URL: https://github.com/apache/datafusion/pull/16319#issuecomment-2959180410
I think I'll put this one in draft for now. Benchmarks results say "needs more work and performance analysis" to me. <details> ``` Comparing baseline and branch -------------------- Benchmark clickbench_extended.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Query ┃ baseline ┃ branch ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ QQuery 0 │ 2827.60 ms │ 2861.15 ms │ no change │ │ QQuery 1 │ 1275.24 ms │ 1271.33 ms │ no change │ │ QQuery 2 │ 2529.29 ms │ 2542.19 ms │ no change │ │ QQuery 3 │ 1082.87 ms │ 1105.09 ms │ no change │ │ QQuery 4 │ 2774.37 ms │ 2834.65 ms │ no change │ │ QQuery 5 │ 32714.77 ms │ 32948.06 ms │ no change │ │ QQuery 6 │ 3662.78 ms │ 3610.34 ms │ no change │ │ QQuery 7 │ 4411.89 ms │ 4412.35 ms │ no change │ │ QQuery 8 │ 1622.98 ms │ 1641.82 ms │ no change │ └──────────────┴─────────────┴─────────────┴───────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (baseline) │ 52901.80ms │ │ Total Time (branch) │ 53226.99ms │ │ Average Time (baseline) │ 5877.98ms │ │ Average Time (branch) │ 5914.11ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 9 │ │ Queries with Failure │ 0 │ └─────────────────────────┴────────────┘ -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ baseline ┃ branch ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 29.01 ms │ 28.68 ms │ no change │ │ QQuery 1 │ 74.78 ms │ 69.50 ms │ +1.08x faster │ │ QQuery 2 │ 159.91 ms │ 167.57 ms │ no change │ │ QQuery 3 │ 183.96 ms │ 188.96 ms │ no change │ │ QQuery 4 │ 1132.22 ms │ 1143.89 ms │ no change │ │ QQuery 5 │ 1439.94 ms │ 1548.88 ms │ 1.08x slower │ │ QQuery 6 │ 46.06 ms │ 43.16 ms │ +1.07x faster │ │ QQuery 7 │ 86.63 ms │ 86.83 ms │ no change │ │ QQuery 8 │ 1840.94 ms │ 1836.42 ms │ no change │ │ QQuery 9 │ 2142.35 ms │ 2141.25 ms │ no change │ │ QQuery 10 │ 562.25 ms │ 551.77 ms │ no change │ │ QQuery 11 │ 612.86 ms │ 647.94 ms │ 1.06x slower │ │ QQuery 12 │ 1692.83 ms │ 1651.23 ms │ no change │ │ QQuery 13 │ 2755.19 ms │ 2699.53 ms │ no change │ │ QQuery 14 │ 1571.17 ms │ 1620.12 ms │ no change │ │ QQuery 15 │ 1619.18 ms │ 1649.79 ms │ no change │ │ QQuery 16 │ 3235.65 ms │ 3235.25 ms │ no change │ │ QQuery 17 │ 2820.07 ms │ 2857.36 ms │ no change │ │ QQuery 18 │ 6210.01 ms │ 5920.66 ms │ no change │ │ QQuery 19 │ 159.65 ms │ 158.77 ms │ no change │ │ QQuery 20 │ 2013.41 ms │ 1929.52 ms │ no change │ │ QQuery 21 │ 2378.85 ms │ 2307.42 ms │ no change │ │ QQuery 22 │ 4003.49 ms │ 4006.98 ms │ no change │ │ QQuery 23 │ 15582.81 ms │ 15369.75 ms │ no change │ │ QQuery 24 │ 911.63 ms │ 875.75 ms │ no change │ │ QQuery 25 │ 749.19 ms │ 748.95 ms │ no change │ │ QQuery 26 │ 1002.11 ms │ 990.34 ms │ no change │ │ QQuery 27 │ 2852.13 ms │ 2868.56 ms │ no change │ │ QQuery 28 │ 22829.31 ms │ 22958.81 ms │ no change │ │ QQuery 29 │ 1192.45 ms │ 1191.21 ms │ no change │ │ QQuery 30 │ 1658.09 ms │ 1697.88 ms │ no change │ │ QQuery 31 │ 1727.92 ms │ 1733.49 ms │ no change │ │ QQuery 32 │ 5707.58 ms │ 5705.04 ms │ no change │ │ QQuery 33 │ 6534.26 ms │ 6312.33 ms │ no change │ │ QQuery 34 │ 6814.26 ms │ 7162.10 ms │ 1.05x slower │ │ QQuery 35 │ 2301.72 ms │ 2423.41 ms │ 1.05x slower │ │ QQuery 36 │ 168.31 ms │ 162.38 ms │ no change │ │ QQuery 37 │ 88.48 ms │ 87.41 ms │ no change │ │ QQuery 38 │ 178.01 ms │ 175.14 ms │ no change │ │ QQuery 39 │ 281.96 ms │ 271.88 ms │ no change │ │ QQuery 40 │ 76.88 ms │ 74.45 ms │ no change │ │ QQuery 41 │ 68.88 ms │ 72.43 ms │ 1.05x slower │ │ QQuery 42 │ 63.90 ms │ 68.55 ms │ 1.07x slower │ └──────────────┴─────────────┴─────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩ │ Total Time (baseline) │ 107560.26ms │ │ Total Time (branch) │ 107441.36ms │ │ Average Time (baseline) │ 2501.40ms │ │ Average Time (branch) │ 2498.64ms │ │ Queries Faster │ 2 │ │ Queries Slower │ 6 │ │ Queries with No Change │ 35 │ │ Queries with Failure │ 0 │ └─────────────────────────┴─────────────┘ -------------------- Benchmark tpch_mem_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ baseline ┃ branch ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 1 │ 220.77 ms │ 237.23 ms │ 1.07x slower │ │ QQuery 2 │ 40.18 ms │ 42.72 ms │ 1.06x slower │ │ QQuery 3 │ 55.84 ms │ 71.40 ms │ 1.28x slower │ │ QQuery 4 │ 35.93 ms │ 40.89 ms │ 1.14x slower │ │ QQuery 5 │ 92.56 ms │ 117.69 ms │ 1.27x slower │ │ QQuery 6 │ 21.60 ms │ 26.50 ms │ 1.23x slower │ │ QQuery 7 │ 180.65 ms │ 291.03 ms │ 1.61x slower │ │ QQuery 8 │ 39.94 ms │ 44.46 ms │ 1.11x slower │ │ QQuery 9 │ 118.20 ms │ 162.73 ms │ 1.38x slower │ │ QQuery 10 │ 78.63 ms │ 117.56 ms │ 1.50x slower │ │ QQuery 11 │ 17.29 ms │ 19.05 ms │ 1.10x slower │ │ QQuery 12 │ 89.51 ms │ 108.56 ms │ 1.21x slower │ │ QQuery 13 │ 59.26 ms │ 66.55 ms │ 1.12x slower │ │ QQuery 14 │ 17.51 ms │ 21.44 ms │ 1.22x slower │ │ QQuery 15 │ 34.14 ms │ 40.69 ms │ 1.19x slower │ │ QQuery 16 │ 39.74 ms │ 39.22 ms │ no change │ │ QQuery 17 │ 146.47 ms │ 145.61 ms │ no change │ │ QQuery 18 │ 430.93 ms │ 423.05 ms │ no change │ │ QQuery 19 │ 52.45 ms │ 53.23 ms │ no change │ │ QQuery 20 │ 74.50 ms │ 79.03 ms │ 1.06x slower │ │ QQuery 21 │ 286.87 ms │ 307.48 ms │ 1.07x slower │ │ QQuery 22 │ 42.56 ms │ 42.50 ms │ no change │ └──────────────┴───────────┴───────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (baseline) │ 2175.53ms │ │ Total Time (branch) │ 2498.61ms │ │ Average Time (baseline) │ 98.89ms │ │ Average Time (branch) │ 113.57ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 17 │ │ Queries with No Change │ 5 │ │ Queries with Failure │ 0 │ └─────────────────────────┴───────────┘ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
