Chen-Yuan-Lai commented on code in PR #16324:
URL: https://github.com/apache/datafusion/pull/16324#discussion_r2138296977
##########
datafusion/core/tests/optimizer/mod.rs:
##########
@@ -107,16 +126,15 @@ fn concat_ws_literals() -> Result<()> {
let sql = "SELECT concat_ws('-', true, col_int32, false, null, 'hello',
col_utf8, 12, '', 3.4) \
AS col
FROM test";
- let expected =
- "Projection: concat_ws(Utf8(\"-\"), Utf8(\"true\"),
CAST(test.col_int32 AS Utf8), Utf8(\"false-hello\"), test.col_utf8,
Utf8(\"12--3.4\")) AS col\
- \n TableScan: test projection=[col_int32, col_utf8]";
- quick_test(sql, expected);
- Ok(())
-}
-
-fn quick_test(sql: &str, expected_plan: &str) {
let plan = test_sql(sql).unwrap();
- assert_eq!(expected_plan, format!("{plan}"));
+ assert_snapshot!(
+ format!("{plan}"),
Review Comment:
Thanks for the comment, the `format!` is exactly unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
