waynexia opened a new pull request, #16356:
URL: https://github.com/apache/datafusion/pull/16356
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
I found that a join plan created using `join_detailed` method with
`null_equals_null` set to `true` will be rewritten to a join plan with
`null_equals_null` set to `false`. This is because optimizer rule
`eliminate_cross_join` will assemble a Join plan and hardcode a `false` value.
This patch fixes that rule and now it will respect the `null_equals_null` flag
from input plan.
A little more background: In a normal SQL model, JOIN and many other places
usually take `null != null`. But I want to leverage JOIN to "concat" two
tables' columns in a PromQL scenario, where I treat `null` as just an identical
vacancy, that requires `null = null`.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
A bug fix to `eliminate_cross_join` plan
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
I wrote a new unit test case to cover this case.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
