chenkovsky commented on code in PR #16333:
URL: https://github.com/apache/datafusion/pull/16333#discussion_r2137107980
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -232,98 +236,244 @@ fn array_has_inner_for_array(haystack: &ArrayRef,
needle: &ArrayRef) -> Result<A
match haystack.data_type() {
DataType::List(_) => array_has_dispatch_for_array::<i32>(haystack,
needle),
DataType::LargeList(_) =>
array_has_dispatch_for_array::<i64>(haystack, needle),
+ DataType::FixedSizeList(_, _) => {
+ array_has_dispatch_for_fixed_size_list_array(haystack, needle)
+ }
_ => exec_err!(
"array_has does not support type '{:?}'.",
haystack.data_type()
),
}
}
+macro_rules! array_has_dispatch_for_array {
Review Comment:
You are right, macro is hard to deal with. so I rewrited it into generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
