zhuqi-lucas commented on code in PR #16196: URL: https://github.com/apache/datafusion/pull/16196#discussion_r2128017451
########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -4702,7 +4702,8 @@ physical_plan 01)CrossJoinExec 02)--DataSourceExec: partitions=1, partition_sizes=[0] 03)--ProjectionExec: expr=[1 as Int64(1)] -04)----PlaceholderRowExec +04)----YieldStreamExec frequency=64 +05)------PlaceholderRowExec Review Comment: I have enabled the flag default to true, for all the slt/testing, only two cases for adding YieldStreamExec, they are PlaceholderRowExec and WorkTableExec. Do we also need to make PlaceholderRowExec and WorkTableExec as a built-in YieldStream? Or it's ok for us to add YieldStreamExec for this two cases? cc @ozankabak @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
