timsaucer commented on code in PR #16170:
URL: https://github.com/apache/datafusion/pull/16170#discussion_r2127368484


##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -6061,7 +6061,7 @@ physical_plan
 04)------AggregateExec: mode=Partial, gby=[], aggr=[count(Int64(1))]
 05)--------ProjectionExec: expr=[]
 06)----------CoalesceBatchesExec: target_batch_size=8192
-07)------------FilterExec: substr(md5(CAST(value@0 AS Utf8)), 1, 32) IN 
([Literal { value: Utf8View("7f4b18de3cfeb9b4ac78c381ee2ad278") }, Literal { 
value: Utf8View("a") }, Literal { value: Utf8View("b") }, Literal { value: 
Utf8View("c") }])
+07)------------FilterExec: substr(md5(CAST(value@0 AS Utf8)), 1, 32) IN 
([Literal { value: Utf8View("7f4b18de3cfeb9b4ac78c381ee2ad278"), field: Field { 
name: "7f4b18de3cfeb9b4ac78c381ee2ad278", data_type: Utf8View, nullable: false, 
dict_id: 0, dict_is_ordered: false, metadata: {} } }, Literal { value: 
Utf8View("a"), field: Field { name: "a", data_type: Utf8View, nullable: false, 
dict_id: 0, dict_is_ordered: false, metadata: {} } }, Literal { value: 
Utf8View("b"), field: Field { name: "b", data_type: Utf8View, nullable: false, 
dict_id: 0, dict_is_ordered: false, metadata: {} } }, Literal { value: 
Utf8View("c"), field: Field { name: "c", data_type: Utf8View, nullable: false, 
dict_id: 0, dict_is_ordered: false, metadata: {} } }])

Review Comment:
   It may play havoc with conversion to SQL but honestly I don't know how we'd 
handle metadata as SQL myself



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to