timsaucer commented on code in PR #16170:
URL: https://github.com/apache/datafusion/pull/16170#discussion_r2127331511
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -111,14 +112,42 @@ pub fn create_physical_expr(
let input_schema: &Schema = &input_dfschema.into();
match e {
- Expr::Alias(Alias { expr, .. }) => {
- Ok(create_physical_expr(expr, input_dfschema, execution_props)?)
+ Expr::Alias(Alias { expr, metadata, .. }) => {
+ if let Expr::Literal(v, prior_metadata) = expr.as_ref() {
+ let mut new_metadata = prior_metadata
+ .as_ref()
+ .map(|m| {
+ m.iter()
+ .map(|(k, v)| (k.clone(), v.clone()))
+ .collect::<HashMap<String, String>>()
+ })
+ .unwrap_or_default();
Review Comment:
When you try doing that there is some trait bound that is unsatisfied that I
didn't spend any more time trying to dig through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
