andygrove commented on code in PR #1830:
URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2127200413
##########
common/src/main/java/org/apache/comet/parquet/TypeUtil.java:
##########
@@ -74,7 +74,7 @@ public static ColumnDescriptor convertToParquet(StructField
field) {
builder = Types.primitive(PrimitiveType.PrimitiveTypeName.INT64,
repetition);
} else if (type == DataTypes.BinaryType) {
builder = Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
repetition);
- } else if (type == DataTypes.StringType) {
+ } else if (type == DataTypes.StringType ||
type.sameType(DataTypes.StringType)) {
Review Comment:
I'm not familiar with the `sameType` method. Why is it needed for strings
but not for the other types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
