alamb commented on code in PR #16209:
URL: https://github.com/apache/datafusion/pull/16209#discussion_r2126757732
##########
datafusion-examples/examples/date_time_functions.rs:
##########
@@ -122,15 +122,15 @@ async fn query_make_date() -> Result<()> {
let df = ctx.sql("select make_date(y + 1, m, d) from t").await?;
let expected = [
- "+-----------------------------------+",
- "| make_date(t.y + Int64(1),t.m,t.d) |",
- "+-----------------------------------+",
- "| 2021-01-15 |",
- "| 2022-02-16 |",
- "| 2023-03-17 |",
- "| 2024-04-18 |",
- "| 2025-05-19 |",
- "+-----------------------------------+",
+ "+-------------------------------------+",
+ "| make_date((t.y + Int64(1)),t.m,t.d) |",
Review Comment:
The parens here seem unecessary (the top most expression) -- I wonder if we
can avoid that somehow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
