zhuqi-lucas commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2939732997
> > @alamb @zhuqi-lucas I've made an alternative sketch of a possible 'intrusive' approach at [pepijnve@9c74748](https://github.com/pepijnve/datafusion/commit/9c74748b7fc1033f29ce6053d898f269e5fb4b90) > > Would love to get your feedback on this. I've tried to take the solution made by @zhuqi-lucas and some inspiration from tokio's coop budget stuff. > > I think it looks good, but it also seems like it doesn't fundamentally change @ozankabak 's concern of having to annotate all streams with cancel aware behavior 🤔 Thank you @pepijnve , the code looks good, i agree it also need to have to annotate all streams with cancel aware behavior. I am wandering if we can have a new design that we don't add YieldExec, but also automatically add the YieldStream support just before the final type operator. @alamb @ozankabak Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
