blaginin commented on PR #16232: URL: https://github.com/apache/datafusion/pull/16232#issuecomment-2939655137
Thanks for the review! > Will this test fail intermittently? It won't fail because of `0` here https://github.com/apache/datafusion/pull/16232/files#diff-08d7a1f4d6a968c393a2a0f2a2f54118f38d6a29009ce31b261f3ca27a2d3396R733 Once https://github.com/apache/datafusion/issues/16228 is fixed, we'll be able to generate null values in _both_ keys _and_ values (will extend the ticket once this PR is merged) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org