pepijnve commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2934462871
> @pepijnve, an intrusive solution will be a hard sell for me. There are simply too many cases, each with their own context and somewhat specific details. @ozankabak could you make that a bit more concrete with an example? It's not 100% clear to me what the concern is precisely. I've been talking to a colleague about this issue and we kind of came to the conclusion that it's preferable for each `Stream` implementation to be a well behaved tokio citizen. Streams that poll in a loop and do not yield when their polled child is always ready is something you should avoid in general I think (cfr. the tokio docs on cooperative scheduling). It's also something that's rather easy to spot locally and also to fix locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
