alamb commented on code in PR #16195:
URL: https://github.com/apache/datafusion/pull/16195#discussion_r2121402980
##########
datafusion/physical-plan/src/metrics/value.rs:
##########
@@ -344,7 +344,7 @@ impl Drop for ScopedTimerGuard<'_> {
/// Among other differences, the metric types have different ways to
/// logically interpret their underlying values and some metrics are
/// so common they are given special treatment.
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone)]
Review Comment:
I agree that keeping the PartialEq would be good
If we can't add PartialEq for `CustomMetricValue` we could potentially
either:
1. Compare based just on name (likely not ideal)
2. impl `PartialEq` manually, and return `None` for any
`MetricValue::Custom` values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
