alamb commented on code in PR #16148:
URL: https://github.com/apache/datafusion/pull/16148#discussion_r2112282534
##########
datafusion/datasource/src/test_util.rs:
##########
@@ -81,6 +83,8 @@ impl FileSource for MockSource {
fn file_type(&self) -> &str {
"mock"
}
+
+ impl_schema_adapter_methods!();
Review Comment:
This would be my preference too -- the `macro` is a nice way to reduce the
boiler plate (and @kosiew has documented it super well) but I think it then
adds a bit more cognative load and it would be better to have a little more
duplication to be explict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
