2010YOUY01 commented on code in PR #16192:
URL: https://github.com/apache/datafusion/pull/16192#discussion_r2110846999
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -658,6 +664,8 @@ impl ExternalSorter {
self.reservation
.try_resize(get_reserved_byte_for_record_batch(&batch))
.map_err(Self::err_with_oom_context)?;
+ // TODO(ding-young) can reservation grow here?
Review Comment:
I think so. After concatenating small batches into a single large batch, it
will allocate new buffers and copy payloads into it, so the size might change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
