gabotechs commented on issue #16044: URL: https://github.com/apache/datafusion/issues/16044#issuecomment-2910200484
👍 This sounds very reasonable, it would be interesting to know what are the stance of DF maintainers on what is considered too coupled to a specific use case vs what is reasonable to ship as extra variants of the `MetricValue` enum. I see that here https://github.com/apache/datafusion/issues/11754#issuecomment-2269674208 there was also a need for another `MetricValue` variant and a custom aggregator was suggested. From what I've seen DataFusion's philosophy tends to lean towards empowering users to provide their own implementations through traits, maybe having custom metrics is not a bad idea if people think that a Distribution type is too coupled to our use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
