irenjj commented on code in PR #16174:
URL: https://github.com/apache/datafusion/pull/16174#discussion_r2105845507
##########
datafusion/optimizer/src/eliminate_cross_join.rs:
##########
@@ -351,6 +353,8 @@ fn find_inner_join(
join_type: JoinType::Inner,
join_constraint: JoinConstraint::On,
null_equals_null: false,
+ dependent_join: false,
Review Comment:
Using a bool is a little strange, so I comment `TODO: maybe it's better to
add a new logical plan: DependentJoin.`
But if we mark dependent join by `JoinType::DependentJoin`, how we can know
the real `JoinType`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
