Rachelint commented on code in PR #16136:
URL: https://github.com/apache/datafusion/pull/16136#discussion_r2101741744
##########
datafusion/physical-plan/src/aggregates/group_values/single_group_by/primitive/mod.rs:
##########
@@ -130,15 +133,15 @@ where
let hash = key.hash(state);
let insert = self.map.entry(
hash,
- |&(g, _)| unsafe {
self.values.get_unchecked(g).is_eq(key) },
Review Comment:
I think for the `large`(> 64bits), we can do that to improve.
But for `normal`(<= 64bits), the new way will be better, I am testing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
