milenkovicm opened a new pull request, #1267:
URL: https://github.com/apache/datafusion-ballista/pull/1267

   # Which issue does this PR close?
   
   Closes #.
   
    # Rationale for this change
   
   previously `job id` is generated randomly, without any ordering guarantees, 
which make is rather hard to determine ordering of jobs, and returning totally 
random results on rest api. Spark is generating job id incrementing atomic int. 
   
   # What changes are included in this PR?
   
   - use atomic integer to generate job id, i do not see valid reason not to do 
it
   - move job id generation from task manager to scheduler (if we later want to 
make it configurable it would be easier to do)
   
   # Are there any user-facing changes?
   
   - no, they might get confused with new job ids 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to