etseidl commented on code in PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#discussion_r2100826502
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -178,7 +182,7 @@ impl FileOpener for ParquetOpener {
// Build predicates for this specific file
let (pruning_predicate, page_pruning_predicate) =
build_pruning_predicates(
predicate.as_ref(),
- &physical_file_schema,
+ &logical_file_schema,
Review Comment:
Sorry, coming to this too late, but I'm curious why the logical schema? To
me pruning implies a physical layer kind of thing. I ask because now I'm having
issues in #15821 trying to build pruning predicates for columns that don't
exist in the physical schema.
This may just mean #15821 is operating at too low a level and needs to
operate up here where we a) know it's parquet and b) have the physical schema.
@alamb @adriangb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
