Dandandan commented on PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2894800268

   Looking at the earlier result
   > │ Q1           │  333.47ms │                375.58ms │  1.13x slower │
   
   This is the query
   ```
           SELECT l_linenumber, l_partkey
           FROM lineitem
           ORDER BY l_linenumber
   ```
   
   So it might actually be the case that the changed code is a bit slower for 
this case. In the query there is only little data to copy (so concat batches -> 
concat sort keys doesn't help that much) while maybe the overhead of using 
interleave_batches is higher 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to