gabotechs commented on code in PR #16064:
URL: https://github.com/apache/datafusion/pull/16064#discussion_r2098183006
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -2711,6 +2724,47 @@ mod tests {
assert_eq!(col.name(), "metric:avg");
}
+
+ #[tokio::test]
+ async fn test_maybe_fix_nested_column_name_with_colon() {
+ let schema = Schema::new(vec![Field::new("column", DataType::Int32,
false)]);
+ let schema_ref: SchemaRef = Arc::new(schema);
+
+ // Construct the nested expr
+ let col_expr = Arc::new(Column::new("column:1", 0)) as Arc<dyn
PhysicalExpr>;
+ let is_not_null_expr = Arc::new(IsNotNullExpr::new(col_expr.clone()));
+
+ // Create a binary expression and put the column inside
+ let binary_expr = Arc::new(BinaryExpr::new(
+ is_not_null_expr.clone(),
+ Operator::Or,
+ is_not_null_expr.clone(),
+ )) as Arc<dyn PhysicalExpr>;
+
+ let fixed_expr =
Review Comment:
Also, confirmed that this test fails on `main` but succeeds in this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
