andygrove commented on code in PR #1710:
URL: https://github.com/apache/datafusion-comet/pull/1710#discussion_r2098159988


##########
native/core/src/execution/planner.rs:
##########
@@ -884,7 +884,7 @@ impl PhysicalPlanner {
                     func_name,
                     fun_expr,
                     vec![left, right],
-                    data_type,
+                    Field::new("foo", data_type, true),

Review Comment:
   There have been changes in DF to use Field rather than DataType. Comet does 
not use the field name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to