andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2093365991
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2758,16 +2758,14 @@ object QueryPlanSerde extends Logging with
CometExprShim {
withInfo(join, "SortMergeJoin is not enabled")
None
- case op
- if isCometSink(op) && op.output.forall(a =>
- supportedDataType(
- a.dataType,
- // Complex type supported if
- // - Native datafusion reader enabled (experimental) OR
- // - conversion from Parquet/JSON enabled
- allowComplex =
- usingDataSourceExec(conf) ||
CometConf.COMET_CONVERT_FROM_PARQUET_ENABLED
- .get(conf) ||
CometConf.COMET_CONVERT_FROM_JSON_ENABLED.get(conf))) =>
Review Comment:
I don't remember why these checks were once necessary but I don't think we
need them now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
