andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2093358984
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -242,15 +240,6 @@ object CometSparkSessionExtensions extends Logging {
org.apache.spark.SPARK_VERSION >= "4.0"
}
- def usingDataSourceExec(conf: SQLConf): Boolean =
- Seq(CometConf.SCAN_NATIVE_ICEBERG_COMPAT,
CometConf.SCAN_NATIVE_DATAFUSION).contains(
- CometConf.COMET_NATIVE_SCAN_IMPL.get(conf))
-
- def usingDataSourceExecWithIncompatTypes(conf: SQLConf): Boolean = {
- usingDataSourceExec(conf) &&
- !CometConf.COMET_SCAN_ALLOW_INCOMPATIBLE.get(conf)
- }
Review Comment:
These methods moved to `CometTestBase` and reduces the number of times we
use these configs in implementation code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
