andygrove commented on code in PR #1730:
URL: https://github.com/apache/datafusion-comet/pull/1730#discussion_r2086717495
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -650,96 +653,97 @@ impl ShufflePartitioner for
MultiPartitionShuffleRepartitioner {
/// This function will slice input batch according to configured batch
size and then
/// shuffle rows into corresponding partition buffer.
async fn insert_batch(&mut self, batch: RecordBatch) -> Result<()> {
- let _ = TraceGuard::new("insert_batch", self.tracing_enabled);
- let start_time = Instant::now();
- let mut start = 0;
- while start < batch.num_rows() {
- let end = (start + self.batch_size).min(batch.num_rows());
- let batch = batch.slice(start, end - start);
- self.partitioning_batch(batch).await?;
- start = end;
- }
- self.metrics.input_batches.add(1);
- self.metrics
- .baseline
- .elapsed_compute()
- .add_duration(start_time.elapsed());
- Ok(())
+ with_trace_async("shuffle_insert_batch", self.tracing_enabled, ||
async {
+ let start_time = Instant::now();
+ let mut start = 0;
+ while start < batch.num_rows() {
+ let end = (start + self.batch_size).min(batch.num_rows());
+ let batch = batch.slice(start, end - start);
+ self.partitioning_batch(batch).await?;
+ start = end;
+ }
+ self.metrics.input_batches.add(1);
+ self.metrics
+ .baseline
+ .elapsed_compute()
+ .add_duration(start_time.elapsed());
+ Ok(())
+ })
+ .await
}
/// Writes buffered shuffled record batches into Arrow IPC bytes.
async fn shuffle_write(&mut self) -> Result<()> {
- let _ = TraceGuard::new("shuffle_write", self.tracing_enabled);
+ with_trace("shuffle_write", self.tracing_enabled, || {
Review Comment:
There is no async code in `shuffle_write`, so I removed the `async` keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
