xudong963 commented on code in PR #15995:
URL: https://github.com/apache/datafusion/pull/15995#discussion_r2080006481
##########
datafusion/physical-optimizer/src/pruning.rs:
##########
@@ -3585,12 +3605,10 @@ mod tests {
prune_with_expr(
// false
- // constant literals that do NOT refer to any columns are
currently not evaluated at all, hence the result is
- // "all true"
Review Comment:
I don't understand why this.
If the predicate is `false`, is it reasonable to return `true`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
